Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more ci #219

Merged
merged 8 commits into from
Dec 8, 2024
Merged

more ci #219

merged 8 commits into from
Dec 8, 2024

Conversation

TroyKomodo
Copy link
Member

Motivation

Solution

Tickets

@codecov Codecov
Copy link

codecov bot commented Dec 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 57.72358% with 52 lines in your changes missing coverage. Please review.

Project coverage is 9.03%. Comparing base (f7814e6) to head (0de05e9).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/bootstrap/telemetry/src/lib.rs 0.00% 34 Missing ⚠️
crates/http/src/backend/quic/body.rs 0.00% 9 Missing ⚠️
crates/batching/src/dataloader.rs 92.10% 0 Missing and 3 partials ⚠️
crates/batching/src/batch.rs 94.73% 0 Missing and 2 partials ⚠️
crates/http/src/backend/quic/mod.rs 0.00% 1 Missing ⚠️
crates/http/src/backend/quic/quinn/serve.rs 0.00% 1 Missing ⚠️
crates/http/src/backend/tcp/serve.rs 0.00% 1 Missing ⚠️
crates/http/src/body.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##            main    #219      +/-   ##
========================================
+ Coverage   6.66%   9.03%   +2.37%     
========================================
  Files         94     101       +7     
  Lines       8645    9569     +924     
  Branches      92     121      +29     
========================================
+ Hits         576     865     +289     
- Misses      8059    8685     +626     
- Partials      10      19       +9
Files with missing lines Coverage Δ
crates/http/src/backend/mod.rs 0.00% <ø> (ø)
crates/http/src/backend/tcp/mod.rs 0.00% <ø> (ø)
crates/http/src/error.rs 0.00% <ø> (ø)
crates/http/src/util.rs 0.00% <ø> (ø)
crates/settings/src/lib.rs 0.00% <ø> (ø)
crates/http/src/backend/quic/mod.rs 0.00% <0.00%> (ø)
crates/http/src/backend/quic/quinn/serve.rs 0.00% <0.00%> (ø)
crates/http/src/backend/tcp/serve.rs 0.00% <0.00%> (ø)
crates/http/src/body.rs 0.00% <0.00%> (ø)
crates/batching/src/batch.rs 97.26% <94.73%> (+97.26%) ⬆️
... and 3 more

... and 8 files with indirect coverage changes

Components Coverage Δ
scuffle-batching 96.97% <93.42%> (+96.97%) ⬆️
scuffle-bootstrap 27.15% <0.00%> (-1.45%) ⬇️
scuffle-context 0.00% <ø> (ø)
scuffle-ffmpeg 0.00% <ø> (ø)
scuffle-h3-webtransport 0.00% <ø> (ø)
scuffle-http 0.00% <0.00%> (ø)
scuffle-metrics 41.54% <ø> (-2.11%) ⬇️
scuffle-pprof 0.00% <ø> (ø)
scuffle-settings 0.00% <ø> (ø)
scuffle-signal 41.86% <ø> (ø)
postcompile 0.00% <ø> (ø)
scuffle-image-processor ∅ <ø> (∅)

@TroyKomodo TroyKomodo marked this pull request as ready for review December 8, 2024 06:13
@TroyKomodo TroyKomodo enabled auto-merge December 8, 2024 06:15
@TroyKomodo TroyKomodo disabled auto-merge December 8, 2024 06:16
@TroyKomodo TroyKomodo added this pull request to the merge queue Dec 8, 2024
Merged via the queue into main with commit 58bcdee Dec 8, 2024
8 checks passed
@TroyKomodo TroyKomodo deleted the troy/coverage branch December 8, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@TroyKomodo